Bram Moolenaar <[email protected]> wrote: > Felipe Contreras wrote: > > > > > > > Processes are not being started correctly with TIOCSCTTY, which does > > > > > > succeed after setsid(). > > > > > > > > > > > > None of that stuff is necessary, including the silencing of SIGHUP. > > > > > > > > > > > > It's not even executed when shellpipe is off. > > > > > > > > > > I suspect removing setsid() will cause trouble if a terminal with a > > > > > shell is started and that shell exits. > > > > > > > > No, I tested that. > > > > > > On which systems? > > > > Linux (5.12.8). > > There are a dozen different Unix-like systems with slightly different > behavior. I care about all of them. It should be possible to at least > test some BSD versions. But there are also SYSV derivatives that > matter, such as HPUX. > > It's difficult to test everything, that is why I prefer to make minimal > changes that actually solve a problem. If we don't know why that > setsid() was there, then removing it probably breaks something.
If a PR is created in github, at least tests would run in CI not only on Linux but also macOs, FreeBSD and Windows. Still, it's only a small subset of all possible platforms, but it may be enough to see whether the change already breaks something. Regards Dominique -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAON-T_jg0TWXgoOmWhv3_6OVizg-MJMr9a0iw2L9kh-pmyPjnA%40mail.gmail.com.
