Hi Christian, On Sun, Jun 20, 2021 at 9:34 AM Christian Brabandt < [email protected]> wrote:
> Hi Bram, thanks for merging. > > The 'swapfile' option is disabled when 'cryptmethod' is set, but no key > has been entered yet. The swapfile should only be disabled when > encryption is actually setup, thus the 'key' option is not empty. > > Are you talking about manually setting the key? E.g. not after :X? It > makes sense, > but manually setting the key should not be done. > > The "corrupted chunk" note is incorrect. We may not be able to > distinguish between a wrong password > > Okay makes sense, will change. > > I wonder why the invalid sample text is so long. > > I was trying to get a file that is written in 2 chunks, so 16384 K. I made > some mistakes, but thought it would be a good test sample nevertheless. > > I'll create a follow-up PR implementing those changes. > > > After merging these changes, the code coverage has gone down (as expected). Can you also take a look at adding additional tests for the new crypto code? Thanks, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7n7%3D0VLBHcUSXRENBbVDkh5RcNwd6DtbhSa2tWSXf2CMQ%40mail.gmail.com.
