On Mo, 05 Jul 2021, Elimar Riesebieter wrote:
> * Christian Brabandt <[email protected]> [2021-07-05 16:32 +0200]: > > > > > On Mo, 05 Jul 2021, Elimar Riesebieter wrote: > > > > > Hi Bram, > > > > > > * Bram Moolenaar <[email protected]> [2021-07-05 14:10 +0200]: > > > > > > > > > > > Patch 8.2.3108 > > > > Problem: Test for remote_foreground() fails. (Elimar Riesebieter) > > > > Solution: Check that $DISPLAY is set. (Christian Brabandt) > > > > Files: src/testdir/check.vim, src/testdir/test_clientserver.vim, > > > > src/testdir/test_vim9_builtin.vim > > > > > > > > > > your patch differs from Christian's version. Compiling 8.2.3108 gives > > > me: > > > > Yes, I also wondered about some of the changes. The problem is, when > > using empty and quoting the argument, the result cannot be true anymore > > > > So I think it needs this change: > > > > diff --git a/src/testdir/check.vim b/src/testdir/check.vim > > index 504a1928e..b2f457074 100644 > > --- a/src/testdir/check.vim > > +++ b/src/testdir/check.vim > > @@ -139,7 +139,7 @@ endfunc > > " Command to Check for an environment variable > > command -nargs=1 CheckEnv call CheckEnv(<f-args>) > > func CheckEnv(name) > > - if empty('$' .. a:name) > > + if empty($ .. a:name) > > throw 'Skipped: Environment variable ' .. a:name .. ' is not set' > > endif > > endfunc > > This Patch fails with: > > Failures: > From test_clientserver.vim: > Found errors in Test_client_server(): > Run 1: > Caught exception in Test_client_server(): Vim(if):E116: Invalid > arguments for function empty($ .. a:name) @ command line..script > /source/vim/vim-8.2.3108/src/vim-gtk3/testdir/runtest.vim[473]..function > RunTheTest[44]..Test_client_server[5]..Check_X11_Connection[2]..CheckEnv, > line 1 > Run 2: > Caught exception in Test_client_server(): Vim(if):E116: Invalid > arguments for function empty($ .. a:name) @ command line..script > /source/vim/vim-8.2.3108/src/vim-gtk3/testdir/runtest.vim[507]..function > RunTheTest[44]..Test_client_server[5]..Check_X11_Connection[2]..CheckEnv, > line 1 > Run 3: > Caught exception in Test_client_server(): Vim(if):E116: Invalid > arguments for function empty($ .. a:name) @ command line..script > /source/vim/vim-8.2.3108/src/vim-gtk3/testdir/runtest.vim[507]..function > RunTheTest[44]..Test_client_server[5]..Check_X11_Connection[2]..CheckEnv, > line 1 > Flaky test failed too often, giving up > From test_vim9_builtin.vim: > Found errors in Test_remote_foreground(): > Caught exception in Test_remote_foreground(): Vim(if):E116: Invalid > arguments for function empty($ .. a:name) @ command line..script > /source/vim/vim-8.2.3108/src/vim-gtk3/testdir/runtest.vim[473]..function > RunTheTest[44]..Test_remote_foreground[4]..CheckEnv, line 1 Hm, can you test and change this: ,---- | if empty('$' .. a:name) `---- to that: ,---- | if !exists('$' .. a:name) `---- Best, Christian -- Gott will, daß der Mensch seinen Spaß hat. -- Theresia von Avila -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20210705153743.GE283422%40256bit.org.
