On 16-Aug-2021 18:24, Bram Moolenaar wrote:

John Marriott wrote:

On 15-Aug-2021 22:32, Bram Moolenaar wrote:
Patch 8.2.3348
Problem:    line2byte() returns wrong value after adding textprop. (Yuto
               Kimura)
Solution:   Reduce the length by the size of the text property. (closes #8759)
Files:      src/memline.c, src/testdir/test_textprop.vim


Hi All,

After this patch, mingw64 (gcc 11.2.0) spits out this error message if
FEAT_PROP_POPUP is not defined:
<snip>
gcc -c -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
-DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO
-pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return
-fpie -fPIE  memline.c -o objnative/memline.o memline.c: In function
'ml_flush_line':
memline.c:4002:24: error: 'buf_T' {aka 'struct file_buffer'} has no
member named 'b_has_textprop'
    4002 |                 if (buf->b_has_textprop)
         |                        ^~
memline.c:4011:24: error: 'buf_T' {aka 'struct file_buffer'} has no
member named 'b_has_textprop'
    4011 |                 if (buf->b_has_textprop)
         |                        ^~
make: *** [Make_cyg_ming.mak:1159: objnative/memline.o] Error 1
</snip>

...
The #ifdef should check both FEAT_BYTEOFF and FEAT_PROP_POPUP, the code
is only needed when both are defined.  I'll make a patch.

Hi Bram,

Now something definitely isn't right. After patch 8.2.3354 I get this
link error (FEAT_PROP_POPUP, FEAT_QUICKFIX and FEAT_SPELL are all
disabled for this build):
This looks like you need to do "make clean".

Hi Bram,

You're right of course. A "make clean" and all is well again.

Thanks

--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/05bfc183-46a6-726e-a44d-0f684fdce9cb%40internode.on.net.

Raspunde prin e-mail lui