> > I'm not sure where you are looking, but I thought that the max tag > > length is a #define used in several places. If you adjust the buffer > > size, that size needs to be communicated to all places that need the > > size. > > I'm looking here, in 'expand_tags': > https://github.com/vim/vim/blob/dea561111a5761bf99397a246b8baa43e73288de/src/tag.c#L3883 > > If there is a globally defined max tag length this buffer isn't using it.
Oh, this is just some temp buffer to copy things around. Should be fine to allocate and reallocate to the right size. > > If there is a missing size check somewhere, increasing the buffer size is > > not the proper solution, it will only fail less often. > > Right, which is why @BGR360 and I proposed allocating the buffer > dynamically. Or we can take @dpelle's suggestion and use a hybrid > approach if minimizing dynamic allocations is important. I guess this function is called once to get a list of all tags, thus the overhead should not be relevant. > > Please mention a reproduction case. Or write a test the fails without the > > fix. > > We have a reproduction case mentioned in the first post of this thread: > https://github.com/neovim/neovim/issues/14026 Should not be difficult to turn this into a test case. -- Yesterday, all my deadlines seemed so far away now it looks as though it's freeze in four days oh I believe in cvs.. [ CVS log "Beatles style" for FreeBSD ports/INDEX, Satoshi Asami ] /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202108191733.17JHXcpN634724%40masaka.moolenaar.net.
