Hi, On Fri, Nov 19, 2021 at 2:05 AM Ben Jackson <[email protected]> wrote:
> *@puremourning* commented on this pull request. > ------------------------------ > > In src/textprop.c > <https://github.com/vim/vim/pull/9138#discussion_r753048618>: > > > > - if (d == NULL) > - break; > - mch_memmove(&prop, text + textlen + i * sizeof(textprop_T), > - sizeof(textprop_T)); > - prop_fill_dict(d, &prop, buf); > - list_append_dict(rettv->vval.v_list, d); > + if (di->di_tv.vval.v_list == NULL) > + return; > + > + prop_ids = get_prop_ids_from_list(di->di_tv.vval.v_list, > + &prop_ids_len); > + if (prop_ids == NULL) > + return; > > does this leak prop_types? There seem to be a few early returns that might > leak one of prop_types or prop_ids. Worth double-checking ? > > > Yes. Thanks for catching this. The tests didn't detect this leak because only 'types' or 'ids' item is used in the test. I have updated the PR with a fix for this and added additional tests. Regards, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7mnPXj5RthXaDns%3DHBe0oqr-BvcDqVVeMG%3D%2B6URD%2BP%3DPQ%40mail.gmail.com.
