James McCoy wrote:
> On Sun, Dec 05, 2021 at 01:03:15PM +0000, Bram Moolenaar wrote: > > > > Patch 8.2.3743 > > Problem: ":sign" can add a highlight group without a name. > > Solution: Give an error if the group name is missing. (closes #9280) > > Files: src/sign.c, src/errors.h, src/testdir/test_signs.vim > > This removes a useful capability. If I've defined a sign as such: > > sign define Foo linehl=FooLine texthl=FooText > > and then want to remove the linehl, I could run > > sign define foo linehl= texthl=FooText > > Now, I have to instead undefine the sign and then define it again. > > This patch causes plugins, like Signify, to error now. I see. Removing the highlight for a defined sign should be OK. But defining a sign the first time with an empty highlight should still be an error, right? -- Every engineer dreams about saving the universe and having sex with aliens. This is much more glamorous than the real life of an engineer, which consists of hiding from the universe and having sex without the participation of other life forms. (Scott Adams - The Dilbert principle) /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org /// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20211205174317.814931C0BD1%40moolenaar.net.
