On Sun, Dec 05, 2021 at 08:17:43PM +0000, Bram Moolenaar wrote: > > James McCoy wrote: > > > On Sun, Dec 05, 2021 at 07:11:00PM +0000, Bram Moolenaar wrote: > > > > > > Patch 8.2.3748 (after 8.2.3747) > > > Problem: Giving an error for an empty sign argument breaks a plugin. > > > Solution: Do not give an error. > > > Files: src/sign.c, src/errors.h, src/testdir/test_signs.vim > > > > Since the error has been reverted, the original issue reported in > > https://github.com/vim/vim/pull/9280 still stands -- this creates a > > highlight group with an empty string for a name. Should that be > > addressed, as was proposed in the PR? > > It should not: > > if (linehl != NULL) > { > if (*linehl == NUL) > sp->sn_line_hl = 0; > else > sp->sn_line_hl = syn_check_group(linehl, (int)STRLEN(linehl)); > } > > With an empty name the highlight group is reset to zero.
Ah, right. Thanks! -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20211205202809.si7hjzc27kaufn5l%40localhost.
