Dominique wrote:
> Should we consider removing -DEXITFREE i.e. always freeing
> memory when exiting without ifdef? I would prefer removing it.
>
> Pros:
> * the fewer ifdef the better (fewer configurations to test)
> * simpler for users/developers to check for leaks, for those
> we do not bother rebuilding Vim with -DEXITREE.
> * we can slightly simplify src/Makefile, runtime/doc/debug.txt
> and code which uses ifdef EXITFREE
> * more chances to find memory errors when exiting and thus
> report and fix them. There are no know such bugs at the
> moment but maybe some exotic platforms or configurations
> have bugs which we're not aware of as most users do not
> rebuild with -DEXITFREE
>
> Cons:
> * slightly bigger vim, but the difference is insignificant
> (+0.23% bigger .text section according to my measurement
> on Linux). See sizes of Vim tiny with/without -DEXITFREE:
>
> ```
> $ size vim-tiy-WITHOUT-DEXITFREE vim-tiny-WITH-DEXITFREE
> text data bss dec hex filename
> 1680633 147704 26056 1854393 1c4bb9
> vim-tiy-WITHOUT-EXITFREE
> 1684654 147712 26056 1858422 1c5b76 vim-tiny-WITH-EXITFREE
> ```
> * bigger risk of crashing when exiting if there is a memory error
There is only a tiny risk of crashing on exit. And it happens when all
files have been written, thus it can't cause trouble.
It's a small advantage to remove some #ifdefs (I count 47), with a small
penalty of some more code. I can't think of a bigger advantage or
disadvantage.
--
hundred-and-one symptoms of being an internet addict:
228. You spend Saturday night making the counter on your home page
pass that 2000 mark.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/20220311120656.E0CF31C0650%40moolenaar.net.
