On 04-Apr-2022 06:10, John Marriott wrote:
On 03-Apr-2022 20:23, Bram Moolenaar wrote:
Patch 8.2.4670
Problem: Memory allocation failures for new tab page not tested.
Solution: Add tests with failing memory allocation. (Yegappan
Lakshmanan,
closes #10067)
Files: src/alloc.h, src/blob.c, src/buffer.c, src/window.c,
src/testdir/test_blob.vim, src/testdir/test_buffer.vim,
src/testdir/test_tabpage.vim,
src/testdir/test_window_cmd.vim
After applying patches 8.2.4670 to 8.2.4677, mingw64 (gcc 11.2.0)
throws this linker error:
<snip>
gcc -I. -Iproto -DWIN32 -DWINVER=0x0603 -D_WIN32_WINNT=0x0603
-DHAVE_PATHDEF -DFEAT_NORMAL -DHAVE_STDINT_H -D__USE_MINGW_ANSI_STDIO
-pipe -march=native -Wall -O3 -fomit-frame-pointer -freg-struct-return
-fpie -fPIE -DFEAT_GUI_MSWIN -DFEAT_CLIPBOARD
-Wl,-nxcompat,-dynamicbase -municode -s -mwindows -o gvim.exe
gobjnative/alloc.o gobjnative/arabic.o gobjnative/arglist.o
gobjnative/autocmd.o gobjnative/beval.o gobjnative/blob.o
gobjnative/blowfish.o gobjnative/buffer.o gobjnative/bufwrite.o
gobjnative/change.o gobjnative/charset.o gobjnative/cindent.o
gobjnative/clientserver.o gobjnative/clipboard.o
gobjnative/cmdexpand.o gobjnative/cmdhist.o gobjnative/crypt.o
gobjnative/crypt_zip.o gobjnative/debugger.o gobjnative/dict.o
gobjnative/diff.o gobjnative/digraph.o gobjnative/drawline.o
gobjnative/drawscreen.o gobjnative/edit.o gobjnative/eval.o
gobjnative/evalbuffer.o gobjnative/evalfunc.o gobjnative/evalvars.o
gobjnative/evalwindow.o gobjnative/ex_cmds.o gobjnative/ex_cmds2.o
gobjnative/ex_docmd.o gobjnative/ex_eval.o gobjnative/ex_getln.o
gobjnative/fileio.o gobjnative/filepath.o gobjnative/findfile.o
gobjnative/float.o gobjnative/fold.o gobjnative/getchar.o
gobjnative/gui_xim.o gobjnative/hardcopy.o gobjnative/hashtab.o
gobjnative/help.o gobjnative/highlight.o gobjnative/if_cscope.o
gobjnative/indent.o gobjnative/insexpand.o gobjnative/json.o
gobjnative/list.o gobjnative/locale.o gobjnative/main.o
gobjnative/map.o gobjnative/mark.o gobjnative/match.o
gobjnative/memfile.o gobjnative/memline.o gobjnative/menu.o
gobjnative/message.o gobjnative/misc1.o gobjnative/misc2.o
gobjnative/mouse.o gobjnative/move.o gobjnative/mbyte.o
gobjnative/normal.o gobjnative/ops.o gobjnative/option.o
gobjnative/optionstr.o gobjnative/os_mswin.o gobjnative/os_win32.o
gobjnative/pathdef.o gobjnative/popupmenu.o gobjnative/popupwin.o
gobjnative/profiler.o gobjnative/quickfix.o gobjnative/regexp.o
gobjnative/register.o gobjnative/scriptfile.o gobjnative/screen.o
gobjnative/search.o gobjnative/session.o gobjnative/sha256.o
gobjnative/sign.o gobjnative/spell.o gobjnative/spellfile.o
gobjnative/spellsuggest.o gobjnative/strings.o gobjnative/syntax.o
gobjnative/tag.o gobjnative/term.o gobjnative/testing.o
gobjnative/textformat.o gobjnative/textobject.o gobjnative/textprop.o
gobjnative/time.o gobjnative/typval.o gobjnative/ui.o
gobjnative/undo.o gobjnative/usercmd.o gobjnative/userfunc.o
gobjnative/version.o gobjnative/vim9cmds.o gobjnative/vim9compile.o
gobjnative/vim9execute.o gobjnative/vim9expr.o gobjnative/vim9instr.o
gobjnative/vim9script.o gobjnative/vim9type.o gobjnative/viminfo.o
gobjnative/winclip.o gobjnative/window.o gobjnative/os_w32exe.o
gobjnative/vimres.o gobjnative/xdiffi.o gobjnative/xemit.o
gobjnative/xprepare.o gobjnative/xutils.o gobjnative/xhistogram.o
gobjnative/xpatience.o gobjnative/gui.o gobjnative/gui_w32.o
gobjnative/gui_beval.o -lkernel32 -luser32 -lgdi32 -ladvapi32
-lcomdlg32 -lcomctl32 -lnetapi32 -lversion -lole32 -luuid
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x11): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x54): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0xe1): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x4e7): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0x70b): undefined reference to
`alloc_clear_id'
d:/users/john/documents/software/mingw/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
gobjnative/blob.o:blob.c:(.text+0xa61): more undefined references to
`alloc_clear_id' follow
collect2.exe: error: ld returned 1 exit status
make: *** [Make_cyg_ming.mak:1107: gvim.exe] Error 2
</snip>
Sorry I don't have a patch.
Cheers
John
Hi All,
The attached patch seems to fix it.
Cheers
John
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/8a88ccea-031d-dfc4-0691-25ee02f05f01%40internode.on.net.
--- alloc.c.orig 2022-03-20 05:27:45.334738100 +1100
+++ alloc.c 2022-04-04 06:14:18.420096800 +1000
@@ -180,7 +180,6 @@
return p;
}
-#if defined(FEAT_SIGNS) || defined(PROTO)
/*
* Same as alloc_clear() but with allocation id for testing
*/
@@ -193,7 +192,6 @@
#endif
return alloc_clear(size);
}
-#endif
/*
* Allocate memory like lalloc() and set all bytes to zero.
