Hi Prabir, On Sat, Apr 16, 2022 at 11:06 PM Prabir Shrestha <[email protected]> wrote:
> Glad that you have a repro. Do watch out for perf issues though this can > be fixed along the way in the near future while the parsing bug is fixed. > In vim-lsp we have a pretty bad perf due to parsing where we concat strings > and this causes lot of memory allocation. > > This threads might be relevant: > > - prabirshrestha/vim-lsp#1073 > <https://github.com/prabirshrestha/vim-lsp/issues/1073> > - hrsh7th/vim-vital-vs@6af4d34 > > <https://github.com/hrsh7th/vim-vital-vs/commit/6af4d3483e5e33d881f9d6da8c766d4bc9b43bf8> > > You might also be interested in how vscode lang server implements it. They > use a MessageBuffer > <https://github.com/microsoft/vscode-languageserver-node/blob/main/jsonrpc/src/common/messageBuffer.ts> > and MessageReader > <https://github.com/microsoft/vscode-languageserver-node/blob/main/jsonrpc/src/common/messageReader.ts> > and directly reading as bytes with allocNative. > > > I have created PR https://github.com/vim/vim/pull/10215 with a fix for this. Can you try it out and let me know if it works with your tests? Thanks, Yegappan -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAAW7x7kuGUWVPw7_3E018WOjJ4kUmyQ5yN4Siy44KqYACp08Hg%40mail.gmail.com.
