Tony wrote:

> Steps to reproduce:
> 0. Make sure that the libsodium is installed on your system.
> 1. Open a fresh bash shell (for example in a nex konsole tab),
> preferably in a shadow directory (in order not to mess with your usual
> build). Make sure your Makefile is unchanged from the distributed
> version.
> 2. Source the following script:
> export CONF_OPT_GUI='--enable-gui=motif'
> export CONF_OPT_MULTIBYTE='--enable-multibyte'
> export CONF_OPT_AUTOSERVE='--enable-autoservername'
> export CONF_OPT_SODIUM='--enable-libsodium'
> export CONF_OPT_FEAT='--with-features=normal'
> export CONF_ARGS2='--with-vim-name=vim-normal'
> export CONF_OPT_COMPBY='"[email protected]"'
> 3. make reconfig
> 4. make install
> 5. vim-normal --version
> 
> Expected result: +sodium in the list of features (i.e. I would have
> expected --enable-libsodium to compile with +sodium even in a Normal
> build).
> 
> Actual result: The list of features includes -sodium at its
> alphabetical place, yet the Linking line includes -lsodium near the
> end.

This is indeed strange.  The configure check for sodium defaults to only
checking when using "huge" features.  That makes sense, it is something
advanced, not always needed.  But in the src/feature.h file the
FEAT_HUGE macro is checked again.  Thus when overriding the configure
check to check for sodium also with "normal" features, it gets excluded
there.  I don't see any reason for that.

I'll make a patch to change this.  Let me know if I missed a situation
where the existing logic did make sense.

-- 
hundred-and-one symptoms of being an internet addict:
24. You realize there is not a sound in the house and you have no idea where
    your children are.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///                                                                      \\\
\\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20230508210859.F2C621C1B21%40moolenaar.net.

Raspunde prin e-mail lui