On 2023-08-10 06:49, Christian Brabandt wrote:
On Mi, 09 Aug 2023, 'Dragan Simic' via vim_dev wrote:
Save and restore the view position before and after saving the buffer,
respectively, to keep the current view of the xxd(1)'s hex dump
unchanged after doing ":w", which previously caused the window to
scroll back to the very beginning of the buffer. I believe it's
needless to say how annoying and counterproductive that was.
Get rid of the "Press ENTER or type command to continue" message,
which
was previously displayed after opening larger binary files. The use
of "silent" and "redraw" commands is tailored specifically to avoid
screen flickering, e.g. when doing ":w", which is caused by the buffer
being filtered by an external command.
Increase the number of octets per line, produced by xxd(1), from the
default value of 16 to 32. This puts bigger chunks of the hex dump
on the screen and makes the whole thing much more usable.
While there, reformat the code to make it more readable, and use the
long form of the commands and variables to make the code slightly more
consistent and more understandable to newcomers.
[...]
Thanks, applied both.
Great, thanks!
BTW: like your commit message, it makes understanding why this change
has been done so much better.
I'm glad you like it. :) It does take a fair amount of time to write
such detailed commit messages, but they're well worth it later, either
to help anyone going through the repository history understand the
changes, or in case any regressions are discovered later.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/b4be0512bec76f968bf68ef76ad6d3cd%40manjaro.org.
