On Mo, 14 Aug 2023, Adri Verhoef wrote:
> > Op 13-08-2023 10:45 CEST schreef Christian Brabandt <[email protected]>: > [..] > > diff --git a/runtime/doc/intro.txt b/runtime/doc/intro.txt > [..] > > @@ -216,7 +217,7 @@ Vim would never have become what it is now, without the > > help of these people! > > Bill Foster Athena GUI port (later removed) > > Google Lets me work on Vim one day a week > > I noticed this: "Lets me work". Bram worked for Google for 15 years, until > September 2021. > Shouldn't this "Lets me" be past tense then, like "Let Bram"? Alternatively: > "Letting Bram". Fixed in https://github.com/vim/vim/pull/12790 > > > diff --git a/LICENSE b/LICENSE > [..] > > @@ -21,8 +21,8 @@ II) It is allowed to distribute a modified (or extended) > > version of Vim, > > maintainer will do with your changes and under what license they > > will be distributed is negotiable. If there has been no > > negotiation > > then this license, or a later version, also applies to your > > changes. > > - The current maintainer is Bram Moolenaar <[email protected]>. If this > > - changes it will be announced in appropriate places (most likely > > + The current maintainers are listed here: > > https://github.com/orgs/vim/people. > > + If this changes it will be announced in appropriate places (most > > likely > > vim.sf.net, www.vim.org and/or comp.editors). When it is > > completely > > impossible to contact the maintainer, the obligation to send him > > your changes ceases. Once the maintainer has confirmed that he > > has > > Above it says: "The current maintainers are listed". > > As we can see, that's plural. Let's watch out for the word "maintainer" then. > > Let's also have another look at the lines above. > > "It is allowed to distribute a modified (or extended) version of Vim", > that's singular ("version of Vim"). Then the next lines: "maintainer will do > with your changes and under what license they will be distributed is > negotiable". > I think this can be split into two parts: the part where the changes are > mentioned > and the part where the license of the version is discussed. 'The changes' > might be plural, but 'the version' is singular. So shouldn't this be "the > maintainers will do with your changes and under what license that version" > (trying to avoid the word 'it' or 'they' after "under what license") then? > > Possibly, the following lines: > > "impossible to contact the maintainer, the obligation to send him > your changes ceases. Once the maintainer has confirmed that he has" > > should then be changed into: > > "impossible to contact the maintainers, the obligation to send them > your changes ceases. Once the maintainers have confirmed that they have" > > There are more locations where "maintainer" is mentioned. Should I list them? > > The same text appears in file uganda.txt: Yes, uganda.txt is basically a copy of the license files. I am a bit hesitant to change this, as I don't want to change the license more than necessary. https://github.com/vim/vim/pull/12749#issuecomment-1678066341 > > > diff --git a/runtime/doc/uganda.txt b/runtime/doc/uganda.txt > [..] > > @@ -46,8 +46,8 @@ II) It is allowed to distribute a modified (or extended) > > version of Vim, > > maintainer will do with your changes and under what license they > > will be distributed is negotiable. If there has been no negotiation > > then this license, or a later version, also applies to your changes. > > - The current maintainer is Bram Moolenaar <[email protected]>. If this > > - changes it will be announced in appropriate places (most likely > > + The current maintainers are listed here: > > https://github.com/orgs/vim/people. > > + If this changes it will be announced in appropriate places (most > > likely > > vim.sf.net, www.vim.org and/or comp.editors). When it is completely > > impossible to contact the maintainer, the obligation to send him > > your changes ceases. Once the maintainer has confirmed that he has > > So the same remarks apply. :-) > > This wasn't changed yet: > > > diff --git a/runtime/indent/README.txt b/runtime/indent/README.txt > [..] > > If you have remarks about an existing file, send them to the maintainer of > > that file. Only when you get no response send a message to [email protected]. fixed in https://github.com/vim/vim/commit/96d6c4aabed15266bc4acfa66f9b35c2820dfa59 > > That should possibly be changed into: > "get no response send a message to the vim-dev mailing list > <[email protected]>." > > The word "me" is also 'suspect': > > > diff --git a/runtime/syntax/model.vim b/runtime/syntax/model.vim > [..] > > -" Maintainer: Bram Moolenaar <[email protected]> > > -" Last Change: 2005 Jun 20 > > +" Maintainer: The Vim Project <https://github.com/vim/vim> > > +" Last Change: 2023 Aug 10 > > +" Former Maintainer: Bram Moolenaar <[email protected]> > > > > " very basic things only (based on the vgrindefs file). > > " If you use this language, please improve it, and send me the patches! > > Maybe change "me" into "us"? Fixed in https://github.com/vim/vim/pull/12780/commits > > diff --git a/src/po/README.txt b/src/po/README.txt > [..] > > You should include your name and E-mail address instead, for example: > > Shouldn't this just be "e-mail" instead of "E-mail"? > > The same applies here: > > > diff --git a/src/po/README_mingw.txt b/src/po/README_mingw.txt > [..] > > You should include your name and E-mail address instead, for example: included here: https://github.com/vim/vim/pull/12753/commits Best, Christian -- Love is a snowmobile racing across the tundra, which suddenly flips over, pinning you underneath. At night the ice weasels come. -- Matt Groening, "Love is Hell" -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/ZNv2M0vpke7jbGKB%40256bit.org.
