Just for reference I was curious why this didn't get caught as an error in CI, it's because optionstr.c compiles with "ALL_IF_CFLAGS" which includes a bunch of "-Wno-error:blah" flags from the different language scripting interfaces, which is why we still see the warnings, but no errors.
On Thu, Oct 5, 2023 at 1:19 PM Christian Brabandt <[email protected]> wrote: > > On Fr, 06 Okt 2023, John Marriott wrote: > > > > > On 06-Oct-2023 06:00, Christian Brabandt wrote: > > > patch 9.0.1991: no cmdline completion for setting the font > > > > > > Commit: > https://github.com/vim/vim/commit/290b887e8cc2c0d3dfc7f315b2052472c7c589cc > > > Author: Yee Cheng Chin<[email protected]> > > > Date: Thu Oct 5 20:54:21 2023 +0200 > > > > > > patch 9.0.1991: no cmdline completion for setting the font > > > Problem: no cmdline completion for setting the font > > > Solution: enable it on Win32 and GTK builds > > > Add guifont cmdline completion (for Windows and GTK) > > > For Windows, auto-complete will only suggest monospace fonts as > that's > > > the only types allowed. Will also suggest font options after the > colon, > > > including suggesting the current font size for convenience, and > misc > > > charset and quality options like `cANSI` and `qCLEARTYPE`. > > > For GTK, auto-complete will suggest only monospace fonts for > `guifont` > > > but will include all fonts for `guifontwide`. The completion code > > > doesn't currently suggest the current font size, as the GTK > guifont > > > format does not have a clear delimiter (':' for other platforms). > > > closes: #13264 > > > Signed-off-by: Christian Brabandt<[email protected]> > > > Co-authored-by: Yee Cheng Chin<[email protected]> > > > > > > > > Hi All, > > > > After this patch, clang 17.0.1 x64 (on msys2 x64, Win 8.1 x64) gives this > > warning for non-gui build: > > <snip> > > optionstr.c:902:1: warning: unused function 'expand_set_opt_callback' > > [-Wunused-function] > > 902 | expand_set_opt_callback( > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > 1 warning generated. > > </snip> > > > > The attached patch tries to fix it. > > > > > Yeah, sorry, already pushed out the same patch v9.0.1993 > > > Thanks, > Christian > -- > There will be big changes for you but you will be happy. > > -- > -- > You received this message from the "vim_dev" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php > > --- > You received this message because you are subscribed to the Google Groups > "vim_dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/vim_dev/ZR8aTcpt0E0xx4q4%40256bit.org. > -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/CAHTeOx80LV9E%2BT1tPK%3DtM783pjX3j%3DQzmVfQ59xBq5FhhV9trQ%40mail.gmail.com.
