I am combining Eisuke Kawashima's changes with my suggested corrections and
other small changes as a separate PR.
Please close #13802 in favor of #13811
On Saturday, December 30, 2023 at 3:46:04 PM UTC-4 Ajit-Thakkar wrote:
> *@Ajit-Thakkar* requested changes on this pull request.
>
> Thank you for all this effort.
>
> I have four small suggestions
>
> Item 1
> On lines 198-202 beginning with 'syn match fortranLabelNumber display'
> the 'ms' and 'me' offsets are equivalent to the \zs and \ze markers.
> Only one pair should be used. I do not know which is more efficient.
> If you like \zs and \ze better, then please change the lines to
>
>
> syn match fortranLabelNumber display "^\zs\d{1,5}\ze\s"
>
> syn match fortranLabelNumber display "^ \zs\d{1,4}\ze\s"
>
> syn match fortranLabelNumber display "^ \zs\d{1,3}\ze\s"
>
> syn match fortranLabelNumber display "^ \zs\d\d=\ze\s"
>
>
> syn match fortranLabelNumber display "^ \zs\d\ze\s"
>
> Item 2
> Please delete line 215
> syn match fortranKeyword "^\s*\zs\d+\s+continue>"
> because it is unnecessary; I left it behind accidentally in a previous
> change of mine.
>
> Item 3
> Both lines 357 and 369 beginning 'syn region fortranModule' contain an
> incorrect
> \z%(
> which should be changed to just
> \z(
> because %() cannot be used after \z
>
> Item 4
> Line 3, please change version from v109 to v110 and update the date
> appropriately.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/vim/vim/pull/13802#pullrequestreview-1799583898>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACY5DGEJSXP7LAUB3W6S2PDYMBVPLAVCNFSM6AAAAABBHIT4X2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJZGU4DGOBZHA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: <vim/vim/pull/13802/review/[email protected]>
>
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/e89e53a4-fca3-41e0-8017-a794f1107157n%40googlegroups.com.
