On So, 28 Jan 2024, Christian Brabandt wrote:
> patch 9.1.0061: UX of visual highlighting can be improved > > Commit: > https://github.com/vim/vim/commit/e6d8b4662ddf9356da53f56e363b67b524fd8825 > Author: Christian Brabandt <[email protected]> > Date: Sun Jan 28 23:33:29 2024 +0100 > > patch 9.1.0061: UX of visual highlighting can be improved > > Problem: UX of visual highlighting can be improved > Solution: Improve readibility of visual highlighting, > by setting better foreground and background > colors > > The default visual highlighting currently is nice in that it overlays > the actual syntax highlighting by using a separate distinct background > color. > > However, this can cause hard to read text, because the contrast > between the actual syntax element and the background color is way too > low. That is an issue, that has been bothering colorschemes authors for > quite some time so much, that they are defining the Visual highlighting > group to use a separate foreground and background color, so that the > syntax highlighting vanishes, but the text remains readable (ref: > vim/colorschemes#250) > > So this is an attempt to perform the same fix for the default Visual > highlighting and just use a default foreground and background color > instead of using reverse. > > I also removed the hard-coded changes to the Visual highlighting in > init_highlight. It's not quite clear to me, why those were there and not > added directly to the highlighting_init_<dark|light> struct. > > closes: #13663 > related: vim/colorschemes#250 > > Signed-off-by: Christian Brabandt <[email protected]> I know this change could be considered quite controversial. However, I hope I have improved readability and UX of visual highlighting quite a bit, even so the syntax highlighting of the visual highlighted items got lost. Let me know if you think this is a problem. Thanks, Christian -- Play Rogue, visit exotic locations, meet strange creatures and kill them. -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/ZbbYE/oWD%2BwbKUcr%40256bit.org.
