On Tuesday, 23 September 2025 at 18:01:04 UTC-4 Tony Mechelynck wrote:
On Tue, Sep 23, 2025 at 11:54 PM Foxe Chen <[email protected]> wrote:
>
>
>
> On Tuesday, 23 September 2025 at 16:30:21 UTC-4 Tony Mechelynck wrote:
>
> On Tue, Sep 23, 2025 at 10:04 PM Christian Brabandt <[email protected]>
wrote:
> >
> > Hi Tony,
> >
> > On Di, 23 Sep 2025, Tony Mechelynck wrote:
> >
> > > On Mon, Sep 22, 2025 at 9:15 PM Christian Brabandt <[email protected]>
wrote:
> > > >
> > > > patch 9.1.1784: Wayland code can be improved
> > > >
> > > > Commit:
https://github.com/vim/vim/commit/368710abcfaadc8370a07cdd58303f2704f10282
> > > > Author: Foxe Chen <[email protected]>
> > > > Date: Mon Sep 22 19:06:58 2025 +0000
> > > >
> > > > patch 9.1.1784: Wayland code can be improved
> > > >
> > > > Problem: Wayland code can be improved
> > > > Solution: Refactor Wayland Clipboard code (Foxe Chen).
> > > >
> > > > This the second attempt to refactor the Wayland code base:
> > > > - Move clipboard code from wayland.c to clipboard.c
> > > [...]
> > >
> > > Build failure in clipboard.c in Normal build with Motif GUI *only*
> > > (not in Huge with GTK3 GUI, and not in Tiny which has -wayland).
> > >
> > > In file included from clipboard.c:36:
> > > wayland.h:17:10: fatal error: wayland-client.h: No such file or
directory
> > > 17 | #include <wayland-client.h>
> > > | ^~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> > > make: *** [Makefile:3238: objects/clipboard.o] Error 1
> >
> > does patch v9.1.1786 fixes it for you again?
> >
> > Thanks,
> > Christian
>
> No, it doesn't, not even if I use "make reconfig". I notice that
> unlike at patch 9.1.1784, at patch 9.1.1786 configure is not run
> automatically by make (for any featureset) and the clipboard.c compile
> line (for Normal with Motif) is still
>
> gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MOTIF -O2
> -fno-strength-reduce -Wall -Wno-deprecated-declarations -D_REENTRANT
> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -o objects/clipboard.o
> clipboard.c
>
>
> with no "wayland" includes — indeed no includes at all other than -I.
-Iproto
>
> Best regards,
> Tony.
>
>
> Does running make -j2 (parallel build) fix the issue?
>
> Thanks,
> Foxe
Normally I use -j4 and this is also what I used this time, first for
"make" and then for "make reconfig". The issue was present in both
cases.
Best regards,
Tony.
Can you try out this patch?
Thanks,
Foxe
diff --git a/src/Makefile b/src/Makefile
index c5697a256..033a2589d 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -1625,7 +1625,7 @@ EXTRA_SRC = if_lua.c if_mzsch.c auto/if_perl.c
if_perlsfio.c \
gui_beval.c netbeans.c job.c channel.c \
$(GRESOURCE_SRC)
-$(WAYLAND_SRC):
+$(WAYLAND_SRC) wayland.h:
cd auto/wayland; $(MAKE)
# Needed for parallel jobs to work
@@ -1633,6 +1633,7 @@ auto/wayland/ext-data-control-v1.h:
auto/wayland/ext-data-control-v1.c
auto/wayland/wlr-data-control-unstable-v1.h:
auto/wayland/wlr-data-control-unstable-v1.c
auto/wayland/primary-selection-unstable-v1.h:
auto/wayland/primary-selection-unstable-v1.c
auto/wayland/xdg-shell.h: auto/wayland/xdg-shell.c
+clipboard.c wayland.c: $(WAYLAND_SRC)
# Unittest files
JSON_TEST_SRC = json_test.c
@@ -3234,7 +3235,7 @@ objects/cindent.o: cindent.c
objects/clientserver.o: clientserver.c
$(CCC) -o $@ clientserver.c
-objects/clipboard.o: clipboard.c $(WAYLAND_SRC)
+objects/clipboard.o: clipboard.c
$(CCC) -o $@ clipboard.c
objects/cmdexpand.o: cmdexpand.c
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/vim_dev/7d8c8faa-2860-40de-928e-ca623e0f02d6n%40googlegroups.com.
