check.vim: Use silent command modifier
Commit:
https://github.com/vim/vim/commit/3456303430a3fd2e628a850f90845cc4cbaa7994
Author: Muraoka Taro <[email protected]>
Date: Wed Jan 21 19:41:58 2026 +0000
check.vim: Use silent command modifier
Problem: When checking a .po file (make -C src/po check), errors are not
displayed.
Solution: Adding "silent" to some normal commands in check.vim
suppresses unnecessary output (Muraoka Taro)
This is because the output of check.vim is redirected to /dev/null.
However, if you stop the redirection, check.vim generates a lot of
output and becomes very slow.
When these commands are run in ex mode, they output the contents of the
line the cursor is pointing to. This caused a lot of output.
closes: #19227
Signed-off-by: Muraoka Taro <[email protected]>
Signed-off-by: Christian Brabandt <[email protected]>
diff --git a/src/po/Makefile b/src/po/Makefile
index ebfb4c1d3..82b6a0922 100644
--- a/src/po/Makefile
+++ b/src/po/Makefile
@@ -42,7 +42,7 @@ converted: $(MOCONVERTED)
.po.ck:
$(VIMPROG) -u NONE --noplugins -e -s -X --cmd "set enc=utf-8" \
-S check.vim -c "if error == 0 | q | else | num 2 | cq | endif"
\
- $< >/dev/null
+ $<
touch $@
check: $(CHECKFILES)
diff --git a/src/po/check.vim b/src/po/check.vim
index 8ecf05a56..f1c60a934 100644
--- a/src/po/check.vim
+++ b/src/po/check.vim
@@ -22,7 +22,7 @@ set nowrapscan
func! GetMline()
let idline = substitute(getline('.'), '"\(.*\)"$', ' ', '')
while line('.') < line('$')
- +
+ silent +
let line = getline('.')
if line[0] != '"'
break
@@ -60,8 +60,8 @@ endfunc
" Start at the first "msgid" line.
let wsv = winsaveview()
-1
-keeppatterns /^msgid\>
+silent 1
+silent keeppatterns /^msgid\>
" When an error is detected this is set to the line number.
" Note: this is used in the Makefile.
@@ -154,7 +154,7 @@ endwhile
" - msgstr "E123 ..." missing colon
" - msgstr "..." missing error code
"
-1
+silent 1
if search('msgid "\("
"\)\?\([EW][0-9]\+:\).*
msgstr "\("
"\)\?[^"]\@= \@!') > 0
echomsg 'Mismatching error/warning code in line ' . line('.')
if error == 0
@@ -164,8 +164,8 @@ endif
" Check that the
at the end of the msgid line is also present in the msgstr
" line. Skip over the header.
-1
-keeppatterns /^"MIME-Version:
+silent 1
+silent keeppatterns /^"MIME-Version:
while 1
let lnum = search('^msgid\>')
if lnum <= 0
@@ -191,8 +191,8 @@ endwhile
" final '""', '
"', ' "' '/"' '."' '-"' are OK
" Beware, it can give false positives if the message is split
" in the middle of a word
-1
-keeppatterns /^"MIME-Version:
+silent 1
+silent keeppatterns /^"MIME-Version:
while 1
let lnum = search('^msgid\>')
if lnum <= 0
@@ -259,7 +259,7 @@ if executable("msgfmt")
endif
" Check that the plural form is properly initialized
-1
+silent 1
let plural = search('^msgid_plural ', 'n')
if (plural && search('^"Plural-Forms: ', 'n') == 0) || (plural &&
search('^msgstr\[0\] ".\+"', 'n') != plural + 1)
if search('^"Plural-Forms: ', 'n') == 0
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/vim_dev/E1vie8X-006xFq-MF%40256bit.org.
