On 10 October 2010 11:34, Bram Moolenaar <[email protected]> wrote: > Björn wrote: >> On 9 October 2010 19:24, Rainer Müller <[email protected]> wrote: >> > >> > as maintainer of vim in MacPorts I got a build failure report [1] when >> > using './configure --with-x' (our +x11 variant): >> > >> > ----snip---- >> > >> > As a solution for this, I added #define NO_X11_INCLUDES at the top of >> > os_macosx.m to avoid the type conflict. Patch attached. >> >> I haven't got much to say about this except I have no objections >> against this patch, but it is up to Bram to merge it since os_macosx.m >> belongs to Vim and not MacVim. > > I asked Rainer to send this to the vim-mac list to get feedback if this > was a good solution. I find it strange to not include X11 files when > configure was run with --with-x. Also, building some .c files with > different header files may lead to problems. Isn't there a better > solution?
I probably don't fully understand this issue, but my take is that nothing inside os_macosx.m does (or should) depend on X11 include files so it seems perfectly safe (and correct) not to include them. Am I missing something? Björn -- You received this message from the "vim_mac" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php
