I don't think this branch is ready to be merged. Since @alloy (and me as well for that matter) has put a fair bit of work into this let me try to outline why.
1. Integration: As soon as you have a nice GUI drawer people immediately want to start mapping keys and customizing it like they can with the rest of vim. Due to the fact that the drawer code lives in a separate process from vim this is not possible. 2. Code quality: In order for the drawer to live in the same window as the text view I had to modify the view code and the stuff that I wrote has a lot of issues. I'll need to rewrite this code at some point anyway since there are problems with views not redrawing properly in the Core Text renderer of the master branch as well. It is a major undertaking. 3. Fragmentation: Having recently been working exclusively on a Linux box I am reminded how wonderful it is to have vim behaving the same across multiple platforms. Introducing new GUI components only for the Mac version is a dubious proposition that I thought I could defend, but I am not so sure anymore. There are more reasons that I can't remember at this point in time, but I think the above three are enough to explain my standpoint. Please don't take this as me saying I am opposed to having GUI drawers. I simply think that if it should be done at all it should be done right. Due to #1 and #3 I really think that a proper implementation should be platform agnostic, but this is much harder. I have for a long time wanted to split MacVim into a view framework and an actual app. This way I could maintain MacVim as a "pure" gvim for Mac and anybody wishing to trick it out with drawers etc could simply reuse the view framework. I even started working on this last summer but got bitten by the "version 2.0 bug" (tried rewriting from scratch and ran out of time/energy). At the moment, if I had the time (I don't), I would like to address #2 and at the same time bring in the smooth trackpad scrolling code that I demonstrated a while back. I'll stop there. I think the fact that we have @alloy's drawer branch is good news for those who wish to have a drawer. Merging it into master does not seem like such an important step to me. Certainly not compared with the issues I outlined above. Björn On Tue, Jan 15, 2013 at 3:54 PM, Bradford Smith <[email protected]> wrote: > It would be so lovely for MacVim to have a working file drawer. I see a fork > exists which tries to add this behavior: https://github.com/alloy/macvim. > Why not try to merge this into the main MacVim repository? > > I already use NERD tree, but it's not quite the same. > > -- > You received this message from the "vim_mac" maillist. > Do not top-post! Type your reply below the text you are replying to. > For more information, visit http://www.vim.org/maillist.php -- -- You received this message from the "vim_mac" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_mac" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
