Yongwei Wu wrote:

> People complained that my recent build of Vim no longer worked with Ruby. I
> reproduced the behaviour. I checked the recent Ruby-related patches, and
> found out that reverting 7.3.834 made it work again.
> 
> Obviously, this part is problematic:
> 
> *** 344,349 ****
> --- 346,362 ----
>   {
>       return dll_rb_int2big(x);
>   }
> + #if defined(DYNAMIC_RUBY_VER) && DYNAMIC_RUBY_VER >= 20
> + VALUE
> + rb_float_new_in_heap(double d)
> + {
> +     return dll_rb_float_new(d);
> + }
> + unsigned long rb_num2ulong(VALUE x)
> + {
> +     return (long)RSHIFT((SIGNED_VALUE)(x),1);
> + }
> + #endif
>   #endif
> 
>   static HINSTANCE hinstRuby = NULL; /* Instance of ruby.dll */
> ***************
> 
> My DYNAMIC_RUBY_VER is defined to 191 and 191 is greater than 20.
> 
> Checking the Makefile carefully confirmed my doubt, since it has a comment
> saying "Don't set ruby API version to RUBY_VER like 191." HOWEVER, the
> in-box bigvim.bat is misleading in that it has "RUBY_VER=192". I just
> followed suit (to an old version).
> 
> So my conclusion is that 7.3.834 is OK, but bigvim.bat should be fixed.
> 
> Makes sense?

Yep.  I'll make a patch.  Let me know if there are other problems, I
hardly ever build on MS-Windows myself.

-- 
An error has occurred.  Hit any user to continue.

 /// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

-- 
-- 
You received this message from the "vim_use" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_use" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to