Excellent, looks good to me, applied, thanks Amos! On Tue, Feb 26, 2013 at 6:46 AM, Amos Kong <[email protected]> wrote: > This patch was wrongly dropped in original refactor. > > Tcpdump brings extra latency, it causes the guest to batch > more bytes per packet. We should stop tcpdump to drop the > effect, it will be restarted at the beginning of next case. > > Reported-by: Wenli Quan <[email protected]> > Signed-off-by: Amos Kong <[email protected]> > --- > tests/netperf.py | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/tests/netperf.py b/tests/netperf.py > index 049b7f1..999b523 100644 > --- a/tests/netperf.py > +++ b/tests/netperf.py > @@ -207,6 +207,14 @@ def run_netperf(test, params, env): > username = params_tmp["username"] > env_setup(i, ip_dict[i], username, shell_port, password) > > + if "tcpdump" in env and env["tcpdump"].is_alive(): > + # Stop the background tcpdump process > + try: > + logging.debug("Stopping the background tcpdump") > + env["tcpdump"].close() > + except Exception: > + pass > + > error.context("Start netperf testing", logging.info) > start_test(server_ip, server_ctl, host, clients, test.resultsdir, > l=int(params.get('l')), > -- > 1.7.1 > > _______________________________________________ > Virt-test-devel mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/virt-test-devel
-- Lucas _______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
