On 02/27/2013 10:20 PM, Alex Jia wrote:

Signed-off-by: Alex Jia<[email protected]>
---
  virttest/libvirt_xml.py |   19 +++++++++++++++++++
  1 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/virttest/libvirt_xml.py b/virttest/libvirt_xml.py
index 3dabf95..9c55b8a 100644
--- a/virttest/libvirt_xml.py
+++ b/virttest/libvirt_xml.py
@@ -511,6 +511,25 @@ class VMXML(VMXMLBase):
          return None


+    def get_numa_params(self, vm_name):
+        """
+        Return VM's numa setting from XML definition
+        """

We now have a _much_ easier way to do this, but it's not a problem. I'll take care of rebasing onto the new libvirt_xml package since it's probably less than obvious for the moment.

However, you're returning a dictionary here is perfect. The new way does the exact same thing, but only needs a single-line addition to the class (and we get "set" & "del" accessor methods for free :)

--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214

_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel

Reply via email to