On 02/28/2013 03:05 AM, Yu Mingfei wrote:
Hi Chris, Alex:
This is v2 version of virsh dumpxml test, and I have added "--inactive"
option's test.
And I have tested both on RHEL5 and RHEL6.
As you said, test of libvirtd's stop/start may be not essential for all
virsh commands', so I removed it.
Yu Mingfei (2):
virt-libvirt: Add configuration for virsh dumpxml test.
virt-libvirt: Add test module for virsh dumpxml.
libvirt/tests/cfg/virsh_dumpxml.cfg | 46 +++++++++++++++++
libvirt/tests/virsh_dumpxml.py | 98 +++++++++++++++++++++++++++++++++++++
2 files changed, 144 insertions(+)
create mode 100644 libvirt/tests/cfg/virsh_dumpxml.cfg
create mode 100644 libvirt/tests/virsh_dumpxml.py
Overall this LGTM. I mention just a few small things. You can fix them
or not, then you can go ahead and push - but please wait to push this
until after freeze :) Thanks.
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
