On Fri, Mar 8, 2013 at 12:10 AM, Yanbing Du <[email protected]> wrote: > > > On 03/08/2013 11:01 AM, Alex Jia wrote: > >> On 03/07/2013 03:48 PM, Yanbing Du wrote: >> >>> https://github.com/autotest/**virt-test/issues/211<https://github.com/autotest/virt-test/issues/211> >>> >>> Introduce virsh dump test: >>> 1) Positive testing >>> 1.1) Dump domain with valid options. >>> 1.2) Avoid file system cache when dumping. >>> 1.3) Compress the dump images to valid/invalid formats. >>> >> >> For invalid formats, it belongs to negative testing. >> > > Yes, u r right. > The problem is: > "if the specified dump_image_format is not valid, or the requested > compression program can't be found, this falls back to "raw" compression." > So, if we put it into negative testing, then we need more work to judge it > as > its return value is "0".
I think this is a very reasonable first iteration. I've pushed it to next. You may improve it and send follow up patches. Thanks guys.
_______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
