On Fri, Apr 05, 2013 at 11:46:51AM -0400, Jiri Zupka wrote: > > > ----- Original Message ----- > > Il 05/04/2013 17:39, Jiri Zupka ha scritto: > > > > > > > > > > > > * For now: > > > 1) filter from in the middle of way. > > > good: > > > only [guest_os=Fedora].15 # makes sense, > > > follows # good too > > > only [guest_os=Fedora]..[fedora_version=15] # This follows > > > the existing rules about "..", but looks weird > > > wrong will not be acceptable by parser: > > > only [guest_os=Fedora.15] # looks wrong to > > > me # less changes in code > > > only [guest_os=Fedora..fedora_version=15] # looks really > > > wrong to me # less changes in code > > > > > > 2) for variants > > > added metadata variants _name_ [default=aaa] [xxx] [yyy]: for > > > possibility future extensibility as you and Pablo mentioned in your > > > responses. > > > > > > 3) default variant could be expanded by parser parameters. Good idea. > > > 4) default should be easy way enabled and disabled. > > > 5) Warning for special characters. > > > > > > Please send me your comments to this part. I'll start work on this as soon > > > as possible. > > > > ACK. > > > > Also, "only [guest_os=Fedora].[15]" should be allowed. > > sure it will be. Sorry for missing it in example.
ACK. Please make sure all variations mentioned above have unit tests (preferably also checking if the incorrect variations will generate errors). Thank you all for the effort! -- Eduardo _______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
