Li: I've been noticing the same mistakes over and over on your patchsets:
1) The patches are usually broken, they have weird line wraps in some lines. We have to fix it manually. 2) Sometimes the indentation is python files is off. We also have to fix it manually. For this one I had to do both. I've been fixing the problems, but clearly this is not sustainable. Please: * Use git-send-email. In fact, it'd be better to just use pull requests, but since we still don't mandate it, please use proper tools to send your work. * Use the checker and reindenter scripts - https://github.com/autotest/autotest/wiki/MaintenanceDocs#tools * Pay attention to https://github.com/autotest/autotest/wiki/TestCodingStyle . This domjobabort test was applied. Thanks. On Mon, Mar 4, 2013 at 5:38 AM, liyang <[email protected]> wrote: > Hi Chris,Alex,Lucas: > I add some more comments to make the test easier to understand. > And I created a topic issue for the patch set... > > https://github.com/autotest/**virt-test/issues/228<https://github.com/autotest/virt-test/issues/228> > > Li Yang (3): > virt-libvirt: add configuration for virsh domjobabort > virt: add virsh function for virsh domjobabort > virt-libvirt: add test module for virsh domjobabort > > libvirt/tests/cfg/virsh_**domjobabort.cfg | 43 ++++++++++++++ > libvirt/tests/virsh_**domjobabort.py | 95 > ++++++++++++++++++++++++++++++**+ > virttest/virsh.py | 11 ++++ > 3 files changed, 149 insertions(+), 0 deletions(-) > create mode 100644 libvirt/tests/cfg/virsh_**domjobabort.cfg > create mode 100644 libvirt/tests/virsh_**domjobabort.py > > -- > Regards, > ------------------------------**-------------------- > Li Yang > TEL：+86+25-86630566-8526 > EMail：[email protected].**com <[email protected]> > ------------------------------**-------------------- > > > > ______________________________**_________________ > Virt-test-devel mailing list > [email protected] > https://www.redhat.com/**mailman/listinfo/virt-test-**devel<https://www.redhat.com/mailman/listinfo/virt-test-devel> > -- Lucas
_______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
