On 05/29/2013 12:12 PM, Lucas Meneghel Rodrigues wrote:
Hello everyone,
After more than a month and most than 370 patches later, I believe the big
merge is mostly done. Thanks to all the great test code contributed so far, and
for all great code reviews.
Great
Thanks everyone for patch reviewing.
Still have several patches need push to upstream. Will finish them this
week.
Thanks
Now, I'll spend less time per day doing code reviews and pushing patches to
next, given that there's a lot of accumulated autotest work just waiting to be
done. We surely don't want to have pull requests starting to accumulate, so I
need some extra cooperation from you all.
What I'd like you guys to keep in mind now is that we need to also share the
responsibility of pushing patches to next. I'd say the expected workflow is:
1) Pull request is proposed
2) One of the maintainers picks the role of primary reviewer, and reviews the
code. The primary reviewer is also responsible for merging/pushing the patchset
to next, and check the patch with check_patch.py.
3) Primary reviewer asks a secondary reviewer for another ACK. If the person
asked can't commit the time, it's fine to decline.
4) Once secondary reviewer gives the other ACK, the primary reviewer can
merge/push to next.
This is fine for me.
+1
What do you guys say? I can document the procedure on the wiki.
Cheers,
Lucas
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
