On 07/25/2013 11:00 AM, Lucas Meneghel Rodrigues wrote: > Folks: > > I've been noticing a lot of people forgetting to do their due dilligence > by running the check_patch.py script in their trees before submitting > patches. I say this because I'm seeing many silly mistakes that could be > easily avoided by doing this simple measure. > > So please, do check and test your stuff before sending it to the mailing > list. I will still double check, because I know people are bound to > forget this, but this doesn't mean you don't have to do what you are > supposed to. > > I will start to reject outright such patches. I have been fixing patches > for a long time now because we had a lot of volume in contributions and > not a lot of maintainers, so either I'd do this or I would drown in > patches. > > Now it's time we start being less forgiving. Also, please be more > mindful of comments and commit messages. We will be asking people to fix > their commit messages as well. > > Thanks, > > Lucas
Tip: # tools/checkpatch --full --yes | grep -v "No name 'client' in module" You can run it in parallel with tools/run_unittests.py also :D Sometimes I run them both three times to make sure I have good karma j/k. But there's no harm in running more than once, only harm in forgetting to run at all :S -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
