On 02/13/2014 08:55 AM, Paolo Bonzini wrote:
The culprit this time is5637ed1... run: Don't overwrite monitors when using --monitor After this patch, this config file will not produce any test anymore: include backends/qemu/cfg/tests-shared.cfg qemu_binary = /usr/libexec/qemu-kvm qemu_img_binary = /usr/bin/qemu-img qemu_io_binary = /usr/bin/qemu-io mem = 3072 skip_hash = 1 only qcow2 only smp2 only no_9p_export only no_pci_assignable only filesystem only smallpages only i440fx no aio_threads only Win7.i386 unattended_install: only default_install Linux: only virtio_net only virtio_blk only extra_cdrom_ks Windows: only unattended_install.cdrom only rtl8139 only ide only floppy_ks only unattended_install.cdrom I tried adding "only qmp" but to no avail. Reverting the patch makes the failure go away. One obvious problem here is that, unlike what was announced in http://permalink.gmane.org/gmane.linux.kernel.autotest.virt-test/2599 the "only hmp" is added even if "-c" is passed on the command line. pro
Ok, my mistake, after thinking about it for a while, I decided to revert the offending hmp/qmp commit:
https://github.com/autotest/virt-test/commit/d54b00006d0b0e9bf10c8c6fe014a81dca5485a3
Also, it makes debugging harder that --list-tests does not print the full test name, so that the output is: 1 io-github-autotest-qemu.unattended_install.cdrom.floppy_ks.default_install.aio_native 2 io-github-autotest-qemu.unattended_install.cdrom.floppy_ks.default_install.aio_native Because of this, I have no idea of _why_ there are still duplicates in the tests. Would it be possible for list-tests to print full tuples? BTW, the tests should use QMP except if running on an old RHEL5 host. HMP is not supported as a management interface.
I agree. The main problem I have with making the change right now is that many prominent tests, that were originally developed even before qmp was a thing still blindly rely on hmp, and some fixing is necessary.
_______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
