On 02/19/2014 10:35 AM, Dongsheng Yang wrote:
There is a cycle import chain as below:utils_test->VMXML->librarian->utils_test. Then we will get a error when we use libvirt_xml: from virttest.libvirt_xml import vm_xml File "/home/yds/github-autotest/github-autotest/client/tests/virt/virttest/libvirt_xml/__init__.py", line 45, in <module> from virttest.libvirt_xml.vm_xml import VMXML File "/home/yds/github-autotest/github-autotest/client/tests/virt/virttest/libvirt_xml/vm_xml.py", line 10, in <module> from virttest.libvirt_xml.devices import librarian File "/home/yds/github-autotest/github-autotest/client/tests/virt/virttest/libvirt_xml/devices/librarian.py", line 6, in <module> import virttest.utils_test File "/home/yds/github-autotest/github-autotest/client/tests/virt/virttest/utils_test/__init__.py", line 38, in <module> import libvirt File "/home/yds/github-autotest/github-autotest/client/tests/virt/virttest/utils_test/libvirt.py", line 25, in <module> from virttest.libvirt_xml import vm_xml ImportError: cannot import name vm_xml This patch remove this unnecessary import line in librarian.
LGTM, pushed to next, thanks!
Signed-off-by: Dongsheng Yang <[email protected]> --- virttest/libvirt_xml/devices/librarian.py | 1 - virttest/libvirt_xml/nwfilter_protocols/librarian.py | 1 - 2 files changed, 2 deletions(-) diff --git a/virttest/libvirt_xml/devices/librarian.py b/virttest/libvirt_xml/devices/librarian.py index f3e4149..f1caf48 100644 --- a/virttest/libvirt_xml/devices/librarian.py +++ b/virttest/libvirt_xml/devices/librarian.py @@ -3,7 +3,6 @@ Module to hide underlying device xml handler class implementation """ import os -import virttest.utils_test from virttest.libvirt_xml import base # Avoid accidental names like __init__, librarian, and/or other support modules diff --git a/virttest/libvirt_xml/nwfilter_protocols/librarian.py b/virttest/libvirt_xml/nwfilter_protocols/librarian.py index 4495553..ed763a6 100644 --- a/virttest/libvirt_xml/nwfilter_protocols/librarian.py +++ b/virttest/libvirt_xml/nwfilter_protocols/librarian.py @@ -3,7 +3,6 @@ Module to hide underlying filter protocol xml handler class implementation """ import os -import virttest.utils_test from virttest.libvirt_xml import base # Avoid accidental names like __init__, librarian, and/or other support modules
_______________________________________________ Virt-test-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-test-devel
