Etherpad: https://autotest.etherpad.mozilla.org/1?

HANGOUT VIDEO: https://www.youtube.com/watch?v=o9JIWUfErNo

Highlights

The dust after the virt test repo split is mostly settled, with bugs fixed and other problems addressed. All the PR addressed to virt-test incorrectly were addressed, and right now virt-test sits on a healthy 26 PR queue. We're getting there.

On other news, I've been cooking up a solution that will get rid of all check_patch.py scripts duplicated in all autotest related projects. Yay!

Commits on master - autotest

Codespell was removed (as part of our remove duplicate scripts initiative), Ross and Nish fixed a couple of small bugs, and Ruda managed to fix the documentation build problems for some delicate parts of autotest. This by itself made the past couple of weeks very productive :)

Lucas Meneghel Rodrigues (5):
      utils: Remove codespell
      tools/check_patch: Remove reference to codespell submodule
      Merge pull request #799 from autotest/remove-codespell
      Merge pull request #801 from rbbratta/fix-apt
      client.shared.file_module_loader: Fix trailing whitespaces

Nishanth Aravamudan (1):
      apache: Fix Django directives to serve cobbler imports of SLES

Ross Brattain (1):
      software_manager: fix inverted logic in AptBackend

Ruda Moura (2):
      documentation: Fix part of the build documentation by using mocking.
      client.shared.report: Set encoding to utf8 and allow customization.

clebergnu (2):
      Merge pull request #802 from ruda/documentation_mocking
      Merge pull request #804 from ruda/client_report_encoding

Commits on master - virt-test

The past couple of weeks has been all about fixing repo split collateral damage. We fixed:
 * Duplicate list of tests
 * Fixed fd leak problems
 * Fixed behavior of the test suite when -c is used
And, as usual, Paolo made another excellent PR that makes virtio-win drivers install to just work out of the box with virt-test.

Dongsheng Yang (3):
      MAINTAINER: Fix the description of LVSB sub testset.
      libvirt_xml: remove the import of utils_test in devices.
      libvirt_xml: fix issues from run_pep8 tool.

Jiří Župka (1):
      virt: Fix bug in removing of remote_sessions.

John Ferlan (2):
      libvirt_vm: set_console_getty() check for systemd
      destroy_pool: Fix return value

Li Yang (1):
      virt: Add ntpdate and get_date function to set and get date time

Lucas Meneghel Rodrigues (21):
      Merge pull request #1428 from autotest/untangle-deps
      virttest.standalone_test: Fix t_type undefined error
virttest.bootstrap: Fix #1426 - subtests.cfg generation for dropin tests
      Merge pull request #1429 from autotest/fix-1426
      Remove tools/codespell
      tools/check_patch: Remove reference to codespell submodule
      Merge pull request #1432 from ldoktor/framework3
      Apply hmp/qmp filters only if -c is not passed in the command line
Revert "Apply hmp/qmp filters only if -c is not passed in the command line"
      Revert "run: Don't overwrite monitors when using --monitor"
      Merge pull request #1430 from ldoktor/framework2
      Merge pull request #1431 from yumingfei/ksm
      Merge pull request #1433 from waynesun09/virsh_sysinfo
      Merge pull request #1434 from jferlan/console_inittab
      Merge pull request #1435 from jferlan/destroy_pool
      Merge pull request #1438 from yangdongsheng/MAINTAINER
      virttest.standalone_test: Close file handler at the end of test
      Merge pull request #1450 from autotest/fd-problem
      Merge pull request #1448 from jzupka/fix_remove_sessions
      Merge pull request #1427 from ldoktor/framework
      Merge pull request #1464 from bonzini/virtio-win

Lukáš Doktor (4):
      templates: Add template difficulty and some comments
      templates: Add couple of templates
      tools.check_patch: Use working dir for project checking
      tools.check_patch: Allow to set AUTOTEST_PATH

Paolo Bonzini (9):
      virtio-win: reorganize restrictions
      virtio-win: commonize virtio_network_installer_path settings
      virtio-win: commonize virtio driver path settings
      virtio-win: automatically add virtio cd for virtio installs
      virtio-win: automatically add virtio floppy for XP and 2k3
      virtio-win: update default paths for latest virtio-win.iso
      virtio-win: add virtio_scsi_path
      virtio-win: remove unused variable
      virtio-win: put virtio ISO together with winutils ISO

Wayne Sun (2):
      virttest.libvirt_xml: Add sysinfo xml handler
      virttest.virsh: Add virsh sysinfo command function

Yang Feng (1):
      Merge pull request #1436 from liyangfnst/time

Yu Mingfei (1):
      virttest.utils_misc: Add KSMController class.

Commits on master - tp-qemu

New cases for ntpd, fixes to qemu-img testcases, spice repo config files update, and updates to test win_virtio_update.

Feng Yang (1):
      Merge pull request #17 from ypu/win_virtio

Li Yang (2):
      tp-qemu:Add a test case for ntpd
      Merge pull request #18 from liyangfnst/ntpd

Lucas Meneghel Rodrigues (4):
      qemu: Move qemu/provider_lib -> provider
      Merge pull request #13 from autotest/provider-libs
      qemu.migration_multi_host_cancel: Clear unused imports
      Merge pull request #15 from swapnakrishnan2k/modify-for-spice

Paolo Bonzini (1):
      cpuid_test_kernel: print all leaves at 0x40000100

Rudá Moura (1):
      Merge pull request #27 from ehabkost/paolo-print-hv-leaves-v1

Shuping Cui (3):
      qemu.tests.cfg: Disable "create -o" option related sub-cases
      qemu.tests.qemu_img: Correct preallocated value
      qemu.tests.qemu_img: Correct create command with -o option

Swapna Krishnan (1):
Modifying config files to deal with new repo changes for Spice testing

Yiqiao Pu (3):
      qemu.tests: Correct the post operate cmd in win_virtio_update
      qemu.tests: Update the virtio cdrom path in win_virtio_update
      Merge pull request #16 from spcui/qemu_img_fix

Commits on master - tp-libvirt

Nothing major happened, except that my proposed solution for avoid changes on virt-test turned out to be a bad idea, as Chris pointed out, and it was reverted.

Lucas Meneghel Rodrigues (4):
      tp-libvirt: Add provider libs
      tp-libvirt: Reorganize imports
      Merge pull request #12 from autotest/provider-libs
      Revert "Merge pull request #12 from autotest/provider-libs"

Commits on master - arc

Basically, I was testing my check_patch.py replacement tool, and found out a bunch of small stuff in arc that needed fixing, so that was the main activity of the week on that repo.

Lucas Meneghel Rodrigues (11):
      arc: Indentation fixes
      arc: Prune unused imports
      arc.tko.test: Fix incorrect reference to TKO_SERVICE_NAME
      arc.testenvironment: Fix incorrect references
      arc.cli.args.testenvironment: Remove non existent ARGUMENTS
      arc.host: Fix oddly indented docstring
      arc.test: Fill docstring data
      arc: Add missing 'modify' methods
      arc.proxy: Supress pylint error E0611
      arc.tko.test: Fix incorrect name exported in __all__
      arc: Fix unused variables

Rudá Moura (1):
      Merge pull request #16 from lmr/inspekt-fixes

Pull requests still in review

Autotest

https://github.com/autotest/autotest/pull/800 -> psstat profiler by Xu Tian. Seems simple and good, will push to next shortly. (I will do it after the hangout --rmoura)

tp-libvirt

32 open PRs ATM:

https://github.com/autotest/tp-libvirt/pulls

In special, jferlan as always has been very active in fixing every possible bug in tp-libvirt tests he can find. Well done!

tp-qemu

12 open PRs ATM:

https://github.com/autotest/tp-qemu/pulls

Yunping is, as always, very active at contributing new tests and fixes to existing tests.

Virt Test

26 open PRs ATM:

https://github.com/autotest/virt-test/pulls

There's a very, very interesting new feature being proposed by Jiri: A remote python shell, which means we don't have to deal with the shell middle man and write our guest tests directly in python, for richer tests and better control:

https://github.com/autotest/virt-test/pull/1449

This, and the other PRs are due review, of course :)

Autotest RPM

As a side note, the RPM is in the main Fedora repository, so thanks to Cleber, for all the work, and Tom Callaway (Spot), for getting us sponsored.

Inspektor

Description of the problem in a nutshell: Once upon a time, there was only the autotest repo. Developers needed a way to check code contributions and overall code health. Then check_patch.py and other scripts were developed and put inside the utils/ directory.

Then everything changed. We split code repos, and spawned new projects. Those new projects also needed some checking love, so what we've done was to replicate check_patch.py and friends everywhere.

Of course, this is horrible from a software maintenance standpoint. As the scripts were doing something similar in all programs, we have multiple copies of code that will be poorly syncrhonized. How to solve this problem?

The answer is to have a stand alone, system wide installable program that does what the original scripts did, so that the said scripts can be deleted. Enter inspektor.

https://github.com/lmr/inspektor

Inspektor is supposed to be installed system wide, using the standard:
python setup.py install

Usage

1) Go to the root of your project source code clone
2) If you want to check code with pylint:
inspekt lint
3) If you want to check indentation:
inspekt indent
4) If you want to check PEP8 compliance:
inspekt style
5) If you want to check github PR 1323:
inspekt github 1323

The program needs quite a lot of work, and once I'm satisfied with its general feature set, all check_patch.py and friends scripts are going to be deleted.

Libvirt updates:
Winding down off of my "Special Project"
Ramping up back onto virt-test maintainership
(i.e. I'm minimally aware of what's happening, so can't add many updates here)

ARC updates:
No news for this week, but
Lucas used the inspektor in the code and found some
minor bugs. (PEP8 compliance and useless imports)

Questions Corner

TODO

lmr

* Keep working on inspekt and PR review (early week)

cevich
*  PR Review
*  Catch up on what I missed in last 3-weeks :(
*  Try to find fix for core<->tp circular deps. w/ env_process

cleber
* Work on database PR v2
* Rebase "installer" branch

jzupka
* finish RFC python remote console
* cartconf changes.
* PR review
* Days off 24-28.2

rmoura
* PR review (#800)
* ARC 0.9.0
  - Add code to modify  options like user, hosts, tests, etc).
  - Add some unit tests.

ldokto
review
rewrite the https://github.com/autotest/tp-qemu/pull/12 test
cleanup my bugzillas... :-/
look at the inspect

kvm-qe (BJ):
Recently we are focusing on bug fix as we want to fix most of the known bugs in our test before tree split.

fyang: works on bug fix and still have cases for sriov
Xutian: block device related bug fix
ypu: misc bug fix and still have one whql case need to be push
yunzheng: Som bug fix and new case related with nic device
xwei, coli, scui and xhan: bug fix

We will on vacation next hangout CST(Jan 30) for Chinese holiday - Spring Festival(about 1 week finished at Feb 6). So we will not online next time. :)

_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel

Reply via email to