On 03/12/2014 11:46 AM, Plamen Dimitrov wrote:
The warnings about missing libvirtd come from a check during
importing of the utils_libvirtd module. The module is imported
in env_process and therefore the warnings appear regardless of
whether we use libvirt or qemu. With this commit the check will
still be performed but the warning is removed.

Signed-off-by: Plamen Dimitrov <[email protected]>
---
  virttest/utils_libvirtd.py | 2 --
  1 file changed, 2 deletions(-)

diff --git a/virttest/utils_libvirtd.py b/virttest/utils_libvirtd.py
index d768d60..8f779bf 100644
--- a/virttest/utils_libvirtd.py
+++ b/virttest/utils_libvirtd.py
@@ -48,8 +48,6 @@ try:
      LIBVIRTD = "libvirtd"
  except ValueError:
      LIBVIRTD = None
-    logging.warning("Libvirtd service is not available in host, "
-                    "utils_libvirtd module will not function normally")

I've never noticed the message because I have the libraries in my test systems. The general idea is OK, but I'd rather move the warning at the function

def service_libvirtd_control

right below LIBVIRTD definition, which is the only function that use it anyway. This way people *wanting* to use the libvirtd control system would know what's going on and people only concerned with qemu would not need to see the message.



  def service_libvirtd_control(action, remote_ip=None,



_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel


_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel

Reply via email to