On Mon, Feb 23, 2015 at 12:45 PM, Swapna Krishnan <[email protected]>
wrote:
Hi,
Just wanted to follow up on this and if I should send out a pull
request for this change?
Thanks,
- Swapna
----- Original Message -----
From: "Swapna Krishnan" <[email protected]>
To: [email protected], "Yiqiao Pu" <[email protected]>
Sent: Friday, February 13, 2015 9:31:23 AM
Subject: Migration tests failing on RHEL7 host
Hi,
I run a few migration tests as part of the SPICE smoketest and I'm
trying to run SPICE smoketest on RHEL7 host. All the migration tests
are failing because of a issue in the test code in qemu_vm.py for
RHEL7.
The command sent to qemu monitor for RHEL7 during migration is
incorrect. "__com.redhat_spice_migrate_info", "spice_migrate_info"
and "client_migrate_info" are the commands sent to qemu monitor
during migration. While running on RHEL7 host, the first 2 commands
are coming up as not supported and "client_migrate_info" is the
command that is sent and the command is framed incorrectly for RHEL7.
The protocol comes before the hostname.
I want to make sure the following change is the correct one that
needs to be done before trying to fix it myself.
Thanks,
- Swapna
--- qemu_vm.py 2015-02-11 13:11:30.592872800 -0500
+++ qemu_vm.py.new 2015-02-12 12:28:23.949678746 -0500
@@ -3361,9 +3361,10 @@
continue
# spice_migrate_info requires host_ip, dest_port
# client_migrate_info also requires protocol
- cmdline = "%s hostname=%s" % (command, host_ip)
+ cmdline = "%s " % (command)
if command == "client_migrate_info":
- cmdline += " ,protocol=%s" %
self.params['display']
+ cmdline += " protocol=%s," %
self.params['display']
+ cmdline += " hostname=%s" % (host_ip)
if dest_port:
cmdline += ",port=%s" % dest_port
if dest_tls_port:
This is correct for RHEL7. Now, our big problems here are RHEL6 and
upstream. As is, this would break those scenarios. The code has to
probe QEMU so we identify which branch we're in so we can use the
appropriate command set.
So your patch is a start, but more work is underway. I probably won't
have enough time to commit to testing across those 3 scenarios and come
up with the final solution. The Beijing folks were on holidays during
the past week and are back now. We can work together to solve this.
Copying the upstream mailing list.
_______________________________________________
Virt-test-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-test-devel
