On 11/05/2010 09:19 AM, Richard W.M. Jones wrote: > > Thanks. I have take up all these suggestions. Would you mind > looking over the small patches attached?
Looks good, with one nit: > - eval `guestfish --listen` > + eval "$(guestfish --listen)" Since the point of patch 1 was to be portable to Solaris /bin/sh, which doesn't understand $(), then patch 2 needs to use: eval "`guestfish --listen`" everywhere. -- Eric Blake [email protected] +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
_______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
