Hi Cole, On Tue, Jul 5, 2011 at 9:40 PM, Cole Robinson <[email protected]> wrote: > On 07/01/2011 04:32 PM, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" <[email protected]> >> >> --- >> virtinst/VirtualDevice.py | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/virtinst/VirtualDevice.py b/virtinst/VirtualDevice.py >> index 87af418..5a6f347 100644 >> --- a/virtinst/VirtualDevice.py >> +++ b/virtinst/VirtualDevice.py >> @@ -27,7 +27,7 @@ class VirtualDevice(XMLBuilderDomain): >> Base class for all domain xml device objects. >> """ >> >> - VIRTUAL_DEV_DISK = "disk" >> + VIRTUAL_DEV_DISK = "block" >> VIRTUAL_DEV_NET = "interface" >> VIRTUAL_DEV_INPUT = "input" >> VIRTUAL_DEV_GRAPHICS = "graphics" > > Please read the HACKING file in the top level of the git checkout:
I did, as per your instructions on IRC. > This > breaks the unit tests (python setup.py test). Yikes, I thought I ran them after this change but I guess I forgot. :( > Also these values > correspond to the device XML name in the libvirt XML schema so should > not be changed. Understood. Not an issue really as we we can either change this in libosinfo instead or map this in virtinst. BTW, I was hoping to get your feedback on the 2nd patch I sent to the list. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
