On Thu, Sep 1, 2011 at 1:37 PM, Daniel P. Berrange <[email protected]> wrote: > On Tue, Aug 30, 2011 at 09:30:15PM +0300, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" <[email protected]> >> +osinfo_detect_LDADD = $(GOBJECT_LIBS) \ >> + $(GIO_LIBS) \ >> + $(LIBXML_LIBS) \ >> + -L$(top_srcdir)/osinfo \ >> + -losinfo-1.0 > > I'm not entirely sure if it has any functional difference, but > I think it is slightly better to remove the -L and -l lines > and instead reference the .la file directly > > ../osinfo/libosinfo-1.0.la > > > ACK, with that change made before pushing
Oh, I already made that change after Cosimo pointed out that it doesn't build for him without it. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
