On Tue, Jul 17, 2012 at 12:59:22PM +0200, Marc-André Lureau wrote: > On Tue, Jul 17, 2012 at 10:59 AM, Christophe Fergeau > <[email protected]> wrote: > > On second thought, shouldn't this be if (!(hint & _HINT_READY)) { } ? I'm > > not sure which flags you are going to add. > > VIRT_VIEWER_DISPLAY_SHOW_HINT_HIDE used to be an enum of value 0, now > there is only a READY flag. The following patch will make this easier > to read.
I've assumed that _READY/_HIDE were just 2 named constant for the same concept, one name for TRUE, another one for FALSE, hence my question. If they are 2 different things, then it would be less confusing to have a HIDE flag as well. Though it's not really important as it's indeed changed in one of the next patches. Christophe
pgpXKafPycN6L.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
