On 04/17/2014 04:08 PM, Giuseppe Scrivano wrote: > Cole Robinson <[email protected]> writes: > >> What that check is trying to fix is the case when a user fills in a URL, auto >> detect is selected, but they never 'activate' the URL text entry so detection >> isn't manually triggered. In that case, we should initiate distro detection >> when the user clicks 'forward'. This change breaks that. >> >> Though off hand I don't know what the proper fix for that bug is, it needs to >> preserve the above behavior though > > ouch, I see. What about bailing out only if the URL is empty? I've > checked that this change doesn't break the case you described and still > "An install tree is required": > > - if curpage == PAGE_INSTALL and self.should_detect_media(): > + if (curpage == PAGE_INSTALL and self.should_detect_media() > + and self.get_config_detectable_media()): > > > Thanks, > Giuseppe >
ACK to that, feel free to push - Cole _______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
