On Mon, Sep 15, 2014 at 6:42 PM, Fabiano Fidêncio <[email protected]> wrote:
> > > On Mon, Sep 15, 2014 at 4:51 PM, Jonathon Jongsma <[email protected]> > wrote: > >> On Mon, 2014-09-15 at 13:46 +0200, Christophe Fergeau wrote: >> > On Mon, Sep 15, 2014 at 01:27:57PM +0200, Fabiano Fidêncio wrote: >> > > On Mon, 2014-09-15 at 13:25 +0200, Christophe Fergeau wrote: >> > > > Hey, >> > > > >> > > > Why not if we want to let the user unobscure the password. The icon >> is a >> > > > bit weird though, I would not know what it's about without clicking >> on >> > > > it. >> > > > Code looks good. >> > > >> > > I loved the icon :-) That's the *only* reason I ended up in >> file-roller >> > > code, looking for the icon name. >> > > Do you have any suggestion about another icon that could be used? >> > >> > Maybe a padlock if there is such an icon? but I guess ideally we'd >> > dynamically change it depending on whether the text is shown or not, ... >> > so most likely not worth the complication. >> > >> >> >> Do you know if there is anybody working on adding this sort of >> functionality in a more generic way into GTK+ itself? > > > I have asked Jakub Steiner (jimmac) for thoughts about the better way to > do this and he didn't mention anything about a more generic way, what makes > me thing there is anyone working on this. > > >> If this feature >> did get added to GTK+ directly, how would that interact with this >> implementation? >> > > If this features get added to GTK+ directly in the future, we can simply > remove this small patch. > *If this feature gets added ... argh! .. Best Regards, -- Fabiano Fidêncio
_______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
