On 12/08/2014 04:43 PM, Gabriel de Perthuis wrote:
Specialised proxies like apt-cacher-ng disallow directory listing. OSDistro subclasses do have checks for known files and they are sufficient. --- virtinst/urlfetcher.py | 5 ----- 1 file changed, 5 deletions(-)diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py index 5a8a98d..25f7066 100644 --- a/virtinst/urlfetcher.py +++ b/virtinst/urlfetcher.py @@ -125,15 +125,10 @@ class _URIImageFetcher(_ImageFetcher): Base class for downloading from FTP / HTTP """ def hasFile(self, filename): raise NotImplementedError - def prepareLocation(self): - if not self.hasFile(""): - raise ValueError(_("Opening URL %s failed.") % - (self.location)) - class _HTTPImageFetcher(_URIImageFetcher): def hasFile(self, filename): try: path = self._make_path(filename)
I always liked that it bails immediately if the URL is mistyped, but we've had enough complaints over the years about this, so I've pushed your patch. Thanks for the contribution!
- Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
