> > On Tue, Apr 14, 2015 at 2:08 PM, Pavel Grunt <[email protected]> > wrote: > > Since the domain name is required as a parameter for the '--wait' > > option (commit a830275344c88aef12166661b68ea2b4429c7212 ), it is > > neccessary to check whether all domains names are the same. > > Otherwise > > it wouldn't be clear which name should be used. > > > > related: rhbz#1211573 > > --- > > src/virt-viewer-main.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/src/virt-viewer-main.c b/src/virt-viewer-main.c > > index 8c1ca80..b2ae0be 100644 > > --- a/src/virt-viewer-main.c > > +++ b/src/virt-viewer-main.c > > @@ -108,6 +108,11 @@ int main(int argc, char **argv) > > goto cleanup; > > } > > > > + if (args && waitvm != NULL && g_strcmp0(waitvm, args[0])) { > > This is a personal preference and you can ignore it if you prefer ... > I'd use compare the g_strcmp0() result explicitly ... like > g_strcmp0() != 0 .... >
Sure, going to send v2. Thanks, Pavel _______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
