On 10/01/2015 07:56 AM, Abhijeet Kasurde wrote:
> Added cli option to specify on_lockfailure in events.
> Also, added various testcases and related output XMLs.
>
> Signed-off-by: Abhijeet Kasurde <[email protected]>
There's a problem here: your change adds on_lockfailure XML to every new guest
we create. In general we don't want to add new unconditional XML, since often
older libvirt will throw errors for unknown XML.
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index e259ad7..8f1be93 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -196,6 +196,7 @@ class Guest(XMLBuilder):
> default_cb=lambda s: "destroy")
> on_reboot = XMLProperty("./on_reboot", default_cb=lambda s: "restart")
> on_crash = XMLProperty("./on_crash", default_cb=lambda s: "restart")
> + on_lockfailure = XMLProperty("./on_lockfailure", default_cb=lambda s:
> "restart")
>
Here, just drop the default_cb usage, regenerate the output, and the patch
should be acceptable.
Thanks,
Cole
> seclabel = XMLChildProperty(Seclabel)
> os = XMLChildProperty(OSXML, is_single=True)
>
_______________________________________________
virt-tools-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-tools-list
