As GTK2 is gone and we have been depending on GLib 2.38 and
GTK 3.10, let's ensure we don't add anything newer than that
(or that at least we get a warning if we do).
Also, clean up all the old code not used anymore and avoid
a bunch of deprecated warnings.
There is one warning that still remains:
virt-viewer-session-vnc.c: In function
'virt_viewer_session_vnc_auth_credential':
virt-viewer-session-vnc.c:272:9: warning: 'g_value_array_get_nth' is
deprecated: Use 'GArray' instead [-Wdeprecated-declarations]
GValue *cred = g_value_array_get_nth(credList, i);
^
In file included from /usr/include/glib-2.0/glib-object.h:35:0,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
from /usr/include/gtk-3.0/gdk/gdk.h:32,
from /usr/include/gtk-3.0/gtk/gtk.h:30,
from virt-viewer-session.h:27,
from virt-viewer-auth.h:32,
from virt-viewer-session-vnc.c:27:
/usr/include/glib-2.0/gobject/gvaluearray.h:63:10: note: declared here
GValue* g_value_array_get_nth (GValueArray *value_array,
^
virt-viewer-session-vnc.c:319:9: warning: 'g_value_array_get_nth' is
deprecated: Use 'GArray' instead [-Wdeprecated-declarations]
GValue *cred = g_value_array_get_nth(credList, i);
^
In file included from /usr/include/glib-2.0/glib-object.h:35:0,
from /usr/include/glib-2.0/gio/gioenums.h:28,
from /usr/include/glib-2.0/gio/giotypes.h:28,
from /usr/include/glib-2.0/gio/gio.h:26,
from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:28,
from /usr/include/gtk-3.0/gdk/gdk.h:32,
from /usr/include/gtk-3.0/gtk/gtk.h:30,
from virt-viewer-session.h:27,
from virt-viewer-auth.h:32,
from virt-viewer-session-vnc.c:27:
/usr/include/glib-2.0/gobject/gvaluearray.h:63:10: note: declared here
GValue* g_value_array_get_nth (GValueArray *value_array,
^
It happens due to a gtk-vnc callback which uses GValueArray. Changing
it would be an API breakage. Introducing new callbacks is the way to
go, but I won't do it right now, as we would still be depending on a
unreleased version of gtk-vnc.
Fabiano Fidêncio (5):
Use GLIB_VERSION_MAX_ALLOWED
Use GDK_VERSION_MAX_ALLOWED
cleanup: Drop old compatibilty code
cleanup: Don't use stock icons
cleanup: Don't use gtk_widget_modify_fg()
acinclude.m4 | 2 +-
configure.ac | 19 +-
po/POTFILES.in | 1 -
src/Makefile.am | 2 -
src/gbinding.c | 1221 -------------------------------------
src/gbinding.h | 129 ----
src/virt-viewer-app.c | 2 -
src/virt-viewer-auth.xml | 8 +-
src/virt-viewer-guest-details.xml | 4 +-
src/virt-viewer-notebook.c | 6 +-
src/virt-viewer-session-spice.c | 6 +-
src/virt-viewer-util.c | 4 -
src/virt-viewer-vm-connection.xml | 8 +-
src/virt-viewer-window.c | 16 +-
src/virt-viewer.xml | 15 +-
15 files changed, 46 insertions(+), 1397 deletions(-)
delete mode 100644 src/gbinding.c
delete mode 100644 src/gbinding.h
--
2.5.0
_______________________________________________
virt-tools-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-tools-list
