On 03/03/2017 02:19 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1420187 > > Signed-off-by: Pavel Hrdina <phrd...@redhat.com> > --- > virtinst/cloner.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtinst/cloner.py b/virtinst/cloner.py > index 5255acfe..ab1f036e 100644 > --- a/virtinst/cloner.py > +++ b/virtinst/cloner.py > @@ -409,7 +409,7 @@ class Cloner(object): > > # Change the XML > xmldisk.path = None > - xmldisk.type = clone_disk.type > + xmldisk.type = orig_disk.type > xmldisk.driver_name = orig_disk.driver_name > xmldisk.driver_type = orig_disk.driver_type > xmldisk.path = clone_disk.path >
This should have a test case. But I don't know if this is right... what if you are cloning from a block device to a file? The type should change in that case and not match the original type. Maybe the root issue of that bug is that VirtualDisk isn't correctly detecting the new path as a block device? - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list
