Hi On Fri, Jun 23, 2017 at 5:34 PM <[email protected]> wrote:
> From: Marc-André Lureau <[email protected]> > > Hi, > > For the reasons explained in this spice-gtk patch series: > https://patchwork.freedesktop.org/patch/161676/, spice-controller > should eventually be removed. We developped the .vv file format as an > alternative for browsers (and other users) to configure the viewer. > > But Jeremy White expressed some concerns about setting up connections > with .vv file. I proposed such use case be covered with a new dbus > interface. See --dbus-controller for more details. > I am not sure this patch makes so much sense. I should start by saying it is lying, it doesn't allow you to write a script with DEST=`remote-viewer --dbus-controller`, as the process will keep running. So getting the dbus bus name isn't obvious. A solution to that is to fork remote-viewer, waiting for the child to connect etc.. not so trivial, not fun. But I realize we don't really need a dbus interface for setting up the connection details without using a writen file. We could just tell remote-viewer to use stdin for the virt-viewer file. So, I am going to send a patch for that instead. > > Comments welcome, > > Marc-André Lureau (6): > file: make constructor accept NULL location > session: remove virt_viewer_session_new() declaration > app: add dbus-ctrl property > remote-viewer: factor our remote_viewer_initial_connect() > remote-viewer: add a --dbus-controller > remote-viewer: remove --spice-controller > > configure.ac | 3 +- > data/Makefile.am | 1 - > data/spice-xpi-client-remote-viewer | 6 - > data/virt-viewer.wxs.in | 3 - > man/remote-viewer.pod | 6 - > src/remote-viewer.c | 698 > ++++++++++++------------------------ > src/remote-viewer.h | 1 + > src/virt-viewer-app.c | 12 + > src/virt-viewer-app.h | 1 + > src/virt-viewer-file.c | 8 +- > src/virt-viewer-session.h | 1 - > 11 files changed, 255 insertions(+), 485 deletions(-) > delete mode 100644 data/spice-xpi-client-remote-viewer > > -- > 2.13.1.395.gf7b71de06 > > _______________________________________________ > virt-tools-list mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/virt-tools-list -- Marc-André Lureau
_______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
