On 12/13/2017 10:24 AM, Michal Privoznik wrote: > On 12/11/2017 07:00 PM, Anthony Serna wrote: >> Patch attached. >> >> Just a small thing I noticed when spinning up an LXC container. > > Hey, > > welcome to the list. Just a couple of hints for your patch: > >> >> >> 0001-strings-fix-typo.patch > > a) We usually send patches directly, not as attachments. You can achieve > this by executing: git send-email ... >> >> >> From 23fdcdbb1c5ee89addc0ef5d745453eaa6b0b235 Mon Sep 17 00:00:00 2001 >> From: Anthony <[email protected]> >> Date: Mon, 11 Dec 2017 09:56:13 -0800 >> Subject: [PATCH] strings: fix typo >> >> --- >> po/as.po | 2 +- >> po/bg.po | 2 +- >> po/bn_IN.po | 2 +- >> po/bs.po | 2 +- >> po/ca.po | 2 +- >> po/cmn.po | 2 +- >> po/cs.po | 2 +- >> po/da.po | 2 +- >> po/de.po | 2 +- >> po/en_GB.po | 2 +- >> po/es.po | 2 +- >> po/fi.po | 2 +- >> po/fr.po | 2 +- >> po/gu.po | 2 +- >> po/hi.po | 2 +- >> po/hr.po | 2 +- >> po/hu.po | 2 +- >> po/is.po | 2 +- >> po/it.po | 2 +- >> po/ja.po | 2 +- >> po/kn.po | 2 +- >> po/ko.po | 2 +- >> po/ml.po | 2 +- >> po/mr.po | 2 +- >> po/ms.po | 2 +- >> po/nb.po | 2 +- >> po/nl.po | 2 +- >> po/or.po | 2 +- >> po/pa.po | 2 +- >> po/pl.po | 4 ++-- >> po/pt.po | 2 +- >> po/pt_BR.po | 2 +- >> po/ro.po | 2 +- >> po/ru.po | 2 +- >> po/sk.po | 2 +- >> po/sr.po | 2 +- >> po/[email protected] | 2 +- >> po/sv.po | 2 +- >> po/ta.po | 2 +- >> po/te.po | 2 +- >> po/tr.po | 2 +- >> po/uk.po | 4 ++-- >> po/vi.po | 2 +- >> po/zh_CN.po | 2 +- >> po/zh_TW.po | 2 +- >> 45 files changed, 47 insertions(+), 47 deletions(-) > > b) these files are generated (despite being tracked in the repo). You > need to fix the root of the bug (which is in ui/create.ui. These po/ > files will be updated then just before the release. >
I agree with Michal's comments, but I fixed the patch for you to just apply to ui/create.ui and pushed Thanks, Cole _______________________________________________ virt-tools-list mailing list [email protected] https://www.redhat.com/mailman/listinfo/virt-tools-list
