On 10/05/2018 10:54 AM, Simon Kobyda wrote:
New Stats Class reduces number of libvirt API calls we do.
However each stats polling has legacy possibility which will be
used when virConnectGetAllDomainStats is not supported by libvirt.
https://bugzilla.redhat.com/show_bug.cgi?id=1264684
Simon Kobyda (2):
Connection: Introduce class for handling statistics.
Domain: Implement new stats class.
virtManager/connection.py | 316 ++++++++++++++++++++++++++++++++++++++
virtManager/domain.py | 256 ++++--------------------------
2 files changed, 348 insertions(+), 224 deletions(-)
Thanks for this! The patches can't really be separated because patch #1
depends on property renaming in patch #2, so I squashed them together. I
also moved the statsmanager class to its own file, and fixed some minor
pylint warnings. This is all pushed now. A couple tips though:
* Connections without AllStats support were broken. It was a small issue
so maybe it snuck in later in dev, but please double check testing. I
fixed this in a follow up commit
* Try not to mix code changes up with code movement/reorg. Ideally this
would have broadly been 1) separate existing code into statsmanager, 2)
add in allstats support. Makes it easier to review that way
Thanks,
Cole
_______________________________________________
virt-tools-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-tools-list
