On Fri, Dec 07, 2018 at 05:02:16PM +0200, Slavomir Kaslev wrote:
> Signed-off-by: Slavomir Kaslev <[email protected]>
> ---
>  ui/addhardware.ui          | 94 ++++++++++++++++++++++++++++++++++++++
>  virtManager/addhardware.py | 33 ++++++++++++-
>  2 files changed, 125 insertions(+), 2 deletions(-)

This patch looks like a lot of code duplication, so I would suggest to
create vsockdetails.py or or similar name and follow the same logic as
for gfxdetails.py and gfxdetails.ui where the files are shared for
details window and addhardware window.

Pavel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
virt-tools-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-tools-list

Reply via email to